Skip to content

Fix SafeAreaPaddingModifier#793

Open
Dark-Existed wants to merge 1 commit intoOpenSwiftUIProject:mainfrom
Dark-Existed:fix_safeareapaddingmodifier
Open

Fix SafeAreaPaddingModifier#793
Dark-Existed wants to merge 1 commit intoOpenSwiftUIProject:mainfrom
Dark-Existed:fix_safeareapaddingmodifier

Conversation

@Dark-Existed
Copy link
Contributor

@Dark-Existed Dark-Existed commented Feb 15, 2026

Fix #511

@augmentcode
Copy link

augmentcode bot commented Feb 15, 2026

🤖 Augment PR Summary

Summary: Fixes SafeAreaPaddingModifier to better match SwiftUI behavior by eliminating unintended extra spacing and honoring the requested edges.

Changes: Adds spacing: 0 to the internal safeAreaInset chain, gates each inset by edges.contains(_:), and re-enables the UI snapshot test for #511.

🤖 Was this summary useful? React with 👍 or 👎

augmentcode[bot]
augmentcode bot reviewed Feb 15, 2026
View reviewed changes
Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Example/OpenSwiftUIUITests/Layout/Modifier/InsetViewModifierUITests.swift
.bug("https://github.com/OpenSwiftUIProject/OpenSwiftUI/issues/511"),
.disabled("Extra spacing value is taken into account. Disable the test case before we fix it.")
)
@Test(.bug("https://github.com/OpenSwiftUIProject/OpenSwiftUI/issues/511"))
Copy link

@augmentcode augmentcode bot Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that SafeAreaPaddingModifier behavior depends on the selected edges, consider adding a snapshot here that exercises a non-.all case (e.g. .safeAreaPadding(.horizontal, 20)) so regressions in edge filtering get caught.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@dill-lk
Copy link

dill-lk commented Feb 19, 2026

hey guys i am intrested in contributing to this project .... are you guys okay with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kyle-Ye Kyle-Ye Awaiting requested review from Kyle-Ye Kyle-Ye is a code owner

1 more reviewer

@augmentcode augmentcode[bot] augmentcode[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: safeAreaPadding API not working correctly

2 participants

@Dark-Existed @dill-lk

Comments